[Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

[Kenneth Graunke]

On Friday, August 11, 2017 4:23:31 AM PDT Grazvydas Ignotas wrote:
> On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > This should hopefully fix build issues on 32-bit Android-x86.
> >
> > Cc: Mauro Rossi <issor.oruam at gmail.com>
> > Cc: Tapani Pälli <tapani.palli at intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050
> > ---
> >  src/mesa/drivers/dri/i965/intel_buffer_objects.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > Mauro, hopefully this helps?
> >
> > diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c b/src/mesa/drivers/dri/i965/intel_buffer_objects.c
> > index ee591168283..9afd98edb87 100644
> > --- a/src/mesa/drivers/dri/i965/intel_buffer_objects.c
> > +++ b/src/mesa/drivers/dri/i965/intel_buffer_objects.c
> > @@ -342,6 +342,7 @@ brw_get_buffer_subdata(struct gl_context *ctx,
> >
> >     unsigned int map_flags = MAP_READ;
> >     mem_copy_fn memcpy_fn = memcpy;
> > +#ifdef USE_SSE4_1
> 
> I don't think anything is defining USE_SSE4_1 in mesa, so you are
> disabling this code for everyone.

Wow.  That's embarassing - I noted this and fixed it for the commit
message, but not the actual code.  Of course, it's annoying that the
runtime check is 4_1 and the preprocessor check is 41...

Thanks for catching this!  Fixed locally.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170811/086ac418/attachment.sig>