[Mesa-dev] [PATCH 07/45] nir: Populate conversion opcodes to/from 16-bit types

[Jason Ekstrand]

On Fri, Aug 18, 2017 at 4:28 AM, Eduardo Lima Mitev <elima at igalia.com>
wrote:

> On 08/17/2017 08:48 PM, Jason Ekstrand wrote:
> > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro <apinheiro at igalia.com
> > <mailto:apinheiro at igalia.com>> wrote:
> >
> >     From: Eduardo Lima Mitev <elima at igalia.com <mailto:elima at igalia.com
> >>
> >
> >     This will include the following NIR ALU opcodes:
> >      * nir_op_i2i16
> >      * nir_op_i2f16
> >      * nir_op_u2u16
> >      * nir_op_u2f16
> >      * nir_op_f2i16
> >      * nir_op_f2u16
> >      * nir_op_f2f16
> >     ---
> >      src/compiler/nir/nir_opcodes_c.py | 2 +-
> >      1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >     diff --git a/src/compiler/nir/nir_opcodes_c.py
> >     b/src/compiler/nir/nir_opcodes_c.py
> >     index a7721d3..01776be 100644
> >     --- a/src/compiler/nir/nir_opcodes_c.py
> >     +++ b/src/compiler/nir/nir_opcodes_c.py
> >     @@ -62,7 +62,7 @@ nir_type_conversion_op(nir_alu_type src,
> >     nir_alu_type dst, nir_rounding_mode rnd
> >      %                 endif
> >      %              endif
> >                     switch (dst_bit_size) {
> >     -%                 for dst_bits in [32, 64]:
> >     +%                 for dst_bits in [16, 32, 64]:
> >
> >
> > You also need to update nir_type_conversion_op in nir_opcodes_c.py.
> >
>
> What do you mean? This hunk is for nir_type_conversion_op in
> nir_opcodes_c.py.
>

drp... I misread it as being for nir_opcodes.py but I guess we have all of
those.  In that case,

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


> > Also, shouldn't this go before patch 6?
> >
>
> Yes, indeed. We have shuffled the patches in the series a few times
> already :). Fixed for v2.
>
> >
> >                        case ${dst_bits}:
> >      %                   if src_t == 'float' and dst_t == 'float'  and
> >     dst_bits == 16:
> >                           switch(rnd) {
> >     --
> >     2.9.3
> >
> >     _______________________________________________
> >     mesa-dev mailing list
> >     mesa-dev at lists.freedesktop.org <mailto:mesa-dev at lists.
> freedesktop.org>
> >     https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >     <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>
> >
> >
> >
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170818/9c3c28a0/attachment.html>