[Mesa-dev] [PATCH v2] From: Emil Velikov <emil.velikov at collabora.com>

Rob Herring robh at kernel.org
Mon Aug 21 16:26:34 UTC 2017


On Mon, Aug 21, 2017 at 9:08 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> As said in the EGL_KHR_platform_android extensions
>
>     For each EGLConfig that belongs to the Android platform, the
>     EGL_NATIVE_VISUAL_ID attribute is an Android window format, such as
>     WINDOW_FORMAT_RGBA_8888.
>
> Although it should be applicable overall.
>
> Even though we use HAL_PIXEL_FORMAT here, those are numerically
> identical to the WINDOW_FORMAT_ and AHARDWAREBUFFER_FORMAT_ ones.
>
> Barring HAL_PIXEL_FORMAT_BGRA_8888 which does not have an equivalent.

The switch to RGB{A,X} from BGRA appears to cause problems for Radeon,
so the android-x86 folks are reverting that change. This change will
break them further. Perhaps the format just needs to be plumbed in.
I'm not sure, but that's been a common problem I've had to fix in
other drivers.

Not saying this isn't the right thing to do. Reverting 3 patches isn't
really much harder than 2.

Rob


More information about the mesa-dev mailing list