[Mesa-dev] [PATCH 02/15] radeonsi/gfx9: prevent shader-db crashes

[Nicolai Hähnle]

On 22.08.2017 13:04, Marek Olšák wrote:
> On Tue, Aug 22, 2017 at 10:14 AM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> On 21.08.2017 23:54, Marek Olšák wrote:
>>>
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> - don't precompile LS and ES (they don't exist on GFX9), compile as VS
>>> instead
>>> - don't precompile HS and GS (we don't have LS and ES parts)
>>
>>
>> Is this true even for the non-monolithic case? Would be nice to have those
>> precompiled for shader-db.
> 
> Non-monolithic shader parts are always precompiled, but they can't be
> used for shader-db, because other shader parts are missing for merged
> shaders.

It would still be interesting to compare statistics for the individual 
parts, otherwise shader-db comparisons would have no coverage of GS/TCS.

> We also can't compile LS and ES monolithically, because the
> compiler doesn't have the capability to compile them, because the
> stages don't exist. Those are always compiled as VS.

Right, but again, at least having some statistics for TES shader-db 
comparisons would be useful.

But anyway, the vast bulk is VS and PS, so this can wait. I'm fine with 
the patch.

Cheers,
Nicolai


> 
> Marek
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.