[Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

[Jason Ekstrand]

On Wed, Aug 23, 2017 at 9:58 AM, Ian Romanick <idr at freedesktop.org> wrote:

> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>
> Did you submit a CTS bug?
>

No, I didn't.  It does get some coverage through the up-and-coming subgroup
tests but it should probably have it's own test.  That's going to be really
annoying to test...


> On 08/21/2017 10:11 PM, Jason Ekstrand wrote:
> > I have no idea how this got missed but it's been missing since forever.
> >
> > Cc: mesa-stable at lists.freedesktop.org
> > ---
> >  src/compiler/spirv/vtn_variables.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/compiler/spirv/vtn_variables.c
> b/src/compiler/spirv/vtn_variables.c
> > index 6a8776b..87cb935 100644
> > --- a/src/compiler/spirv/vtn_variables.c
> > +++ b/src/compiler/spirv/vtn_variables.c
> > @@ -1121,6 +1121,10 @@ vtn_get_builtin_location(struct vtn_builder *b,
> >        *location = FRAG_RESULT_DEPTH;
> >        assert(*mode == nir_var_shader_out);
> >        break;
> > +   case SpvBuiltInHelperInvocation:
> > +      *location = SYSTEM_VALUE_HELPER_INVOCATION;
> > +      set_mode_system_value(mode);
> > +      break;
> >     case SpvBuiltInNumWorkgroups:
> >        *location = SYSTEM_VALUE_NUM_WORK_GROUPS;
> >        set_mode_system_value(mode);
> > @@ -1177,7 +1181,6 @@ vtn_get_builtin_location(struct vtn_builder *b,
> >        *location = SYSTEM_VALUE_VIEW_INDEX;
> >        set_mode_system_value(mode);
> >        break;
> > -   case SpvBuiltInHelperInvocation:
> >     default:
> >        unreachable("unsupported builtin");
> >     }
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170823/373543b2/attachment.html>