[Mesa-dev] [PATCH 01/14] mesa: add bind_transform_feedback() helper

[Ilia Mirkin]

On Thu, Aug 24, 2017 at 9:21 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/mesa/main/transformfeedback.c | 28 ++++++++++++++++++----------
>  1 file changed, 18 insertions(+), 10 deletions(-)
>
> diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c
> index a075d0875a..d61db4eb62 100644
> --- a/src/mesa/main/transformfeedback.c
> +++ b/src/mesa/main/transformfeedback.c
> @@ -1062,10 +1062,26 @@ _mesa_IsTransformFeedback(GLuint name)
>   * Bind the given transform feedback object.
>   * Part of GL_ARB_transform_feedback2.
>   */
> +static ALWAYS_INLINE void
> +bind_transform_feedback(struct gl_context *ctx, GLuint name, bool no_error)
> +{
> +   struct gl_transform_feedback_object *obj;
> +
> +   obj = _mesa_lookup_transform_feedback_object(ctx, name);
> +   if (!no_error && !obj) {
> +      _mesa_error(ctx, GL_INVALID_OPERATION,
> +                  "glBindTransformFeedback(name=%u)", name);
> +      return;
> +   }
> +
> +   reference_transform_feedback_object(&ctx->TransformFeedback.CurrentObject,
> +                                       obj);

Is the CurrentObject allowed to be null (which it could be in the
no-error case)?