[Mesa-dev] [PATCH] i965: Simplify MOCS mashing in genX_state_upload.c.

[Kenneth Graunke]

On Thursday, August 24, 2017 4:04:26 AM PDT Lionel Landwerlin wrote:
> Looks good, but it looks like you could replace an additional one in 
> upload_push_constant_packets().

That one is a bit weird - it uses 0 on Gen8+.  I've wondered about that,
actually - the docs claim that you must use 0 - but at least on Skylake,
0 is an entry in the table that means uncached.  So is the requirement
that the bits be 0, or the requirement that you bypass caching?

Things we'll never know I guess.  I'm not sure if it matters, though,
since it's just pulling the data into a segment of the L3 anyway...so
it's only read one time...

At any rate, I left it open coded because it's different than the others.

> Also why not name it GEN_MOCS ? (so it's a bit more consistent with 
> other macros defined per gen).
> 
> Thanks!

I like this.  Changed locally.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170824/ffb880ea/attachment.sig>