[Mesa-dev] [PATCH mesa] egl/android: add missing include

Rob Herring robh at kernel.org
Thu Aug 24 15:22:27 UTC 2017


On Thu, Aug 24, 2017 at 10:09 AM, Tapani Pälli <tapani.palli at intel.com> wrote:
>
>
> On 08/24/2017 06:02 PM, Rob Herring wrote:
>>
>> On Thu, Aug 24, 2017 at 9:26 AM, Rob Herring <robh at kernel.org> wrote:
>>>
>>> On Thu, Aug 24, 2017 at 9:22 AM, Eric Engestrom
>>> <eric.engestrom at imgtec.com> wrote:
>>>>
>>>> Cc: Rob Herring <robh at kernel.org>
>>>> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
>>>> ---
>>>> This needs to land before [1], otherwise the latter will break android.
>>>>
>>>> [1]
>>>> https://lists.freedesktop.org/archives/mesa-dev/2017-August/167428.html
>>>>
>>>>   src/egl/drivers/dri2/platform_android.c | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>
>>>
>>> For both patches:
>>>
>>> Reviewed-by: Rob Herring <robh at kernel.org>
>>
>>
>> Actually, on further examination I think this isn't needed. egl_dri2.h
>> includes system/window.h which in turn includes native_window.h. I'll
>> test out the EGL change without this.
>>
>
> Not 100% sure but you might need include for android_native_rect_t from
> 'arect' lib, it was moved there from 'nativewindow' lib

I checked this. At least for O it is implicitly added as an include
path by libnativewindow.

Rob


More information about the mesa-dev mailing list