[Mesa-dev] [PATCH mesa] egl/android: add missing include

[Chih-Wei Huang]

2017-08-24 22:22 GMT+08:00 Eric Engestrom <eric.engestrom at imgtec.com>:
> Cc: Rob Herring <robh at kernel.org>
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
> This needs to land before [1], otherwise the latter will break android.
>
> [1] https://lists.freedesktop.org/archives/mesa-dev/2017-August/167428.html
>
>  src/egl/drivers/dri2/platform_android.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c
> index a864a2af3d..36fc5833b4 100644
> --- a/src/egl/drivers/dri2/platform_android.c
> +++ b/src/egl/drivers/dri2/platform_android.c
> @@ -27,6 +27,7 @@
>   * DEALINGS IN THE SOFTWARE.
>   */
>
> +#include <android/native_window.h>
>  #include <errno.h>
>  #include <dlfcn.h>
>  #include <fcntl.h>
> --

NACK.
This breaks Android O sinlce
the include path was changed.

external/mesa/src/egl/drivers/dri2/platform_android.c:30:10: fatal
error: 'android/native_window.h' file not found
#include <android/native_window.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


Actually Android O builds with [1] perfectly
without this one.

Not tested in pre-O.
We (android-x86) have no plan to use
the master branch with pre-O.


-- 
Chih-Wei
Android-x86 project
http://www.android-x86.org