[Mesa-dev] [PATCH 15/16] i965: drop brw->has_surface_tile_offset in favor of devinfo's

[Lionel Landwerlin]

On 30/08/17 11:40, Emil Velikov wrote:
> On 30 August 2017 at 11:07, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>
>> --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
>> +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
>> @@ -79,6 +79,7 @@ get_isl_surf(struct brw_context *brw, struct intel_mipmap_tree *mt,
>>
>>      const enum isl_dim_layout dim_layout =
>>         get_isl_dim_layout(&brw->screen->devinfo, mt->surf.tiling, target);
>> +   const struct gen_device_info *devinfo = &brw->screen->devinfo;
> Annotate as MAYBE_UNUSED/UNUSED?

Thanks, I can make use of it in previous line :)

>
>>      if (surf->dim_layout == dim_layout)
>>         return;
>> @@ -92,7 +93,7 @@ get_isl_surf(struct brw_context *brw, struct intel_mipmap_tree *mt,
>>       * texel of the level instead of relying on the usual base level/layer
>>       * controls.
>>       */
>> -   assert(brw->has_surface_tile_offset);
>> +   assert(devinfo->has_surface_tile_offset);
>>      assert(view->levels == 1 && view->array_len == 1);
>>      assert(*tile_x == 0 && *tile_y == 0);
>>
> FWIW the series is
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>
> -Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev