[Mesa-dev] [PATCH v2 3/7] intel: emit first_vertex and reorder the VE' components

[Kenneth Graunke]

On Tuesday, December 5, 2017 3:23:03 PM PST Kenneth Graunke wrote:
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

It turns out that patches 1-3 by themselves cause piles of Piglit and
CTS failures.  Please make sure the series doesn't cause regressions at
each step along the way.

For reference, here are some of the failures I noticed when testing:

piglit.spec.arb_draw_indirect.gl_vertexid used with gldrawarraysindirect
piglit.spec.arb_draw_indirect.gl_vertexid used with gldrawelementsindirect
piglit.spec.arb_gpu_shader_fp64.shader_storage.layout-std140-fp64-shader
piglit.spec.arb_shader_draw_parameters.baseinstance [Gen6-7.5 only?]
piglit.spec.arb_shader_draw_parameters.drawid-indirect-baseinstance
piglit.spec.arb_shader_draw_parameters.drawid-indirect-basevertex
piglit.spec.arb_shader_draw_parameters.drawid-indirect-vertexid
piglit.spec.arb_shader_draw_parameters.drawid-vertexid
piglit.spec.arb_shader_storage_buffer_object.layout-std140-write-shader
piglit.spec.arb_shader_storage_buffer_object.layout-std430-write-shader
piglit.spec.glsl-1_50.transform-feedback-vertex-id
piglit.spec.!opengl 3_0.gl_vertexid used with glmultidrawarrays
piglit.spec.!opengl 3_2.gl_vertexid used with glmultidrawelementsbasevertex
piglit.spec.!opengl es 3_0.gl_vertexid used with gldrawarrays
dEQP-GLES31.functional.draw_base_vertex.draw_elements_base_vertex.builtin_variable.vertex_id
dEQP-GLES31.functional.draw_base_vertex.draw_elements_instanced_base_vertex.builtin_variable.vertex_id
dEQP-GLES31.functional.draw_base_vertex.draw_range_elements_base_vertex.builtin_variable.vertex_id
dEQP-GLES31.functional.primitive_bounding_box.clear.full_clear_with_triangles
dEQP-GLES31.functional.primitive_bounding_box.clear.scissored_clear_with_triangles
dEQP-GLES3.functional.shaders.builtin_variable.vertex_id
KHR-GL46.clip_distance.functional
KHR-GL46.draw_elements_base_vertex_tests.AEP_shader_stages
KHR-GL46.draw_elements_base_vertex_tests.basevertex_behavior1
KHR-GL46.draw_elements_base_vertex_tests.overflow
KHR-GL46.draw_elements_base_vertex_tests.underflow
KHR-GL46.enhanced_layouts.vertex_attrib_locations
KHR-GL46.geometry_shader.rendering.rendering.lines_input_line_strip_output_line_loop_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_input_line_strip_output_lines_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_input_line_strip_output_line_strip_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_input_points_output_line_loop_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_input_points_output_lines_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_input_points_output_line_strip_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_line_loop_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_lines_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_line_strip_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_with_adjacency_input_line_strip_output_lines_adjacency_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_with_adjacency_input_line_strip_output_line_strip_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_with_adjacency_input_points_output_lines_adjacency_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_with_adjacency_input_points_output_line_strip_drawcall
KHR-GL46.geometry_shader.rendering.rendering.lines_with_adjacency_input_triangle_strip_output_lines_adjacency_drawcall
KHR-GL46.geometry_shader.rendering.rendering.points_input_line_strip_output
KHR-GL46.geometry_shader.rendering.rendering.points_input_points_output
KHR-GL46.geometry_shader.rendering.rendering.points_input_triangles_output
KHR-GL46.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangle_fan_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangles_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangle_strip_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_input_points_output_triangle_fan_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_input_points_output_triangles_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_input_points_output_triangle_strip_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangle_fan_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangles_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangle_strip_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_with_adjacency_input_line_strip_output_triangles_adjacency_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_with_adjacency_input_line_strip_output_triangle_strip_adjacency_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_with_adjacency_input_points_output_triangles_adjacency_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_with_adjacency_input_points_output_triangle_strip_adjacency_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_with_adjacency_input_triangle_strip_output_triangles_adjacency_drawcall
KHR-GL46.geometry_shader.rendering.rendering.triangles_with_adjacency_input_triangle_strip_output_triangle_strip_adjacency_drawcall
KHR-GL46.shader_draw_parameters_tests.MultiDrawArraysIndirectCountParameters
KHR-GL46.shader_draw_parameters_tests.MultiDrawElementIndirectCountParameters
KHR-GL46.shader_draw_parameters_tests.ShaderMultiDrawArraysIndirectParameters
KHR-GL46.shader_draw_parameters_tests.ShaderMultiDrawElementsIndirectParameters
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_input_line_strip_output_line_loop_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_input_line_strip_output_lines_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_input_line_strip_output_line_strip_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_input_points_output_line_loop_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_input_points_output_lines_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_input_points_output_line_strip_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_line_loop_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_lines_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_line_strip_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_line_strip_output_lines_adjacency_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_points_output_lines_adjacency_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_points_output_line_strip_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_triangle_strip_output_lines_adjacency_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_triangle_strip_output_line_strip_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.points_input_line_strip_output
KHR-GLES31.core.geometry_shader.rendering.rendering.points_input_points_output
KHR-GLES31.core.geometry_shader.rendering.rendering.points_input_triangles_output
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangle_fan_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangles_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangle_strip_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_input_points_output_triangle_fan_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_input_points_output_triangles_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_input_points_output_triangle_strip_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangle_fan_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangles_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangle_strip_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_line_strip_output_triangles_adjacency_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_points_output_triangles_adjacency_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_points_output_triangle_strip_adjacency_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_triangle_strip_output_triangles_adjacency_drawcall
KHR-GLES31.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_triangle_strip_output_triangle_strip_adjacency_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_input_line_strip_output_line_loop_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_input_line_strip_output_lines_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_input_line_strip_output_line_strip_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_input_points_output_line_loop_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_input_points_output_lines_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_input_points_output_line_strip_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_line_loop_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_lines_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_line_strip_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_line_strip_output_lines_adjacency_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_line_strip_output_line_strip_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_points_output_lines_adjacency_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_points_output_line_strip_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_triangle_strip_output_lines_adjacency_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.lines_with_adjacency_input_triangle_strip_output_line_strip_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.points_input_line_strip_output
KHR-GLES32.core.geometry_shader.rendering.rendering.points_input_points_output
KHR-GLES32.core.geometry_shader.rendering.rendering.points_input_triangles_output
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangle_fan_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangles_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangle_strip_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_input_points_output_triangle_fan_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_input_points_output_triangles_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_input_points_output_triangle_strip_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangle_fan_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangles_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangle_strip_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_line_strip_output_triangles_adjacency_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_line_strip_output_triangle_strip_adjacency_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_points_output_triangles_adjacency_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_points_output_triangle_strip_adjacency_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_triangle_strip_output_triangles_adjacency_drawcall
KHR-GLES32.core.geometry_shader.rendering.rendering.triangles_with_adjacency_input_triangle_strip_output_triangle_strip_adjacency_drawcall
KHR-GLESEXT.draw_elements_base_vertex_tests.AEP_shader_stages
KHR-GLESEXT.draw_elements_base_vertex_tests.basevertex_behavior1
KHR-GLESEXT.draw_elements_base_vertex_tests.overflow
KHR-GLESEXT.draw_elements_base_vertex_tests.underflow
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_input_line_strip_output_line_loop_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_input_line_strip_output_lines_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_input_line_strip_output_line_strip_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_input_points_output_line_loop_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_input_points_output_lines_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_input_points_output_line_strip_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_line_loop_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_lines_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_input_triangle_strip_output_line_strip_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_with_adjacency_input_line_strip_output_lines_adjacency_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_with_adjacency_input_line_strip_output_line_strip_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_with_adjacency_input_points_output_lines_adjacency_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_with_adjacency_input_points_output_line_strip_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_with_adjacency_input_triangle_strip_output_lines_adjacency_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.lines_with_adjacency_input_triangle_strip_output_line_strip_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.points_input_line_strip_output
KHR-GLESEXT.geometry_shader.rendering.rendering.points_input_points_output
KHR-GLESEXT.geometry_shader.rendering.rendering.points_input_triangles_output
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangle_fan_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangles_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_input_line_strip_output_triangle_strip_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_input_points_output_triangle_fan_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_input_points_output_triangles_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_input_points_output_triangle_strip_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangle_fan_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangles_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_input_triangle_strip_output_triangle_strip_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_with_adjacency_input_line_strip_output_triangles_adjacency_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_with_adjacency_input_line_strip_output_triangle_strip_adjacency_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_with_adjacency_input_points_output_triangles_adjacency_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_with_adjacency_input_points_output_triangle_strip_adjacency_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_with_adjacency_input_triangle_strip_output_triangles_adjacency_drawcall
KHR-GLESEXT.geometry_shader.rendering.rendering.triangles_with_adjacency_input_triangle_strip_output_triangle_strip_adjacency_drawcall
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171211/e5680cdc/attachment.sig>