[Mesa-dev] [PATCH 4/4] anv/device: Mark all state buffers as needing capture

[Jason Ekstrand]

Thanks!  I've pushed the last 3.  I'll let the debate continue on 1/4. :-)

On Thu, Dec 28, 2017 at 9:25 AM, Lionel Landwerlin <
lionel.g.landwerlin at intel.com> wrote:

> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>
>
> On 27/12/17 20:58, Jason Ekstrand wrote:
>
>> Previously, we were flagging the instruction state buffer for capture
>> but not surface state or dynamic state.  We want those captured too.
>> ---
>>   src/intel/vulkan/anv_device.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.
>> c
>> index 4638f31..680f5a7 100644
>> --- a/src/intel/vulkan/anv_device.c
>> +++ b/src/intel/vulkan/anv_device.c
>> @@ -1251,7 +1251,8 @@ VkResult anv_CreateDevice(
>>         goto fail_batch_bo_pool;
>>        /* For the state pools we explicitly disable 48bit. */
>> -   bo_flags = physical_device->has_exec_async ? EXEC_OBJECT_ASYNC : 0;
>> +   bo_flags = (physical_device->has_exec_async ? EXEC_OBJECT_ASYNC : 0)
>> |
>> +              (physical_device->has_exec_capture ? EXEC_OBJECT_CAPTURE
>> : 0);
>>        result = anv_state_pool_init(&device->dynamic_state_pool, device,
>> 16384,
>>                                   bo_flags);
>> @@ -1259,8 +1260,7 @@ VkResult anv_CreateDevice(
>>         goto fail_bo_cache;
>>        result = anv_state_pool_init(&device->instruction_state_pool,
>> device, 16384,
>> -                                bo_flags |
>> -                                (physical_device->has_exec_capture ?
>> EXEC_OBJECT_CAPTURE : 0));
>> +                                bo_flags);
>>      if (result != VK_SUCCESS)
>>         goto fail_dynamic_state_pool;
>>
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171228/6616df45/attachment.html>