[Mesa-dev] [PATCH] wayland-drm: update use of struct wl_resource to avoid deprecated struct definition

Emil Velikov emil.l.velikov at gmail.com
Wed Feb 8 15:23:56 UTC 2017

On 8 February 2017 at 13:42, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Tue,  7 Feb 2017 17:29:53 -0500
> Micah Fedke <micah.fedke at collabora.co.uk> wrote:
Where is the commit message ? Here is what comes to mind here, feel
free to reuse.

"As of Wayland vX the $NEW_API was introduced to replace the
deprecated $STRUCT_FOO. Seemingly due to a unrelated bug $REFERENCE
none of the deprecation warning triggered."

> Hi,
> this looks good to me:
> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> It would also be good to add #define WL_HIDE_DEPRECATED to all
> wayland-related .c files before #includes so that the compiler will
> catch any attempts to use the deprecated definitions again.
Fully agree, but let's keep it follow-up patch. I'm split if we should
#define in each .c files or once in build system.
The latter sounds shorter + more robust.


More information about the mesa-dev mailing list