[Mesa-dev] [Bug 99730] Metro Redux game(s) needs override for midshader extension declaration

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=99730

            Bug ID: 99730
           Summary: Metro Redux game(s) needs override for midshader
                    extension declaration
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Mesa core
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: eero.t.tamminen at intel.com
        QA Contact: mesa-dev at lists.freedesktop.org

Created attachment 129435
  --> https://bugs.freedesktop.org/attachment.cgi?id=129435&action=edit
drirc patch

Use-case:
- Install Steam & Metro 2033 Redux game
- Run game and switch it to High gfx quality
- Run again with warnings enabled

Actual outcome (from apitrace replay):
- This:
--------------------
warning: compilation failed
warning: 0:16(1): error: #extension directive is not allowed in the middle of a
shader
warning: link failed
warning: error: linking with uncompiled shader
warning: link failed
warning: error: linking with uncompiled shader
--------------------
- And tens of these during startup & browsing game options:
--------------------
warning: glGetError(glUseProgram) = GL_INVALID_OPERATION
warning: program validation failed
--------------------

That shader seems to be used only during loading & menus, and I didn't notice
any obvious rendering issues, but may be still better to add drirc workaround
for it.  See attached patch for an example.

Note: I don't have Metro Last Light Redux, but it may have the same issue and
same binary name.  Earlier non-Redux version of MetroLL didn't have this issue,
and has different binary name.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170209/ec62bb12/attachment-0001.html>