[Mesa-dev] [PATCH] st/va: remove assert for single slice

[Andy Furniss]

Nayan Deshmukh wrote:
> Hi Andy,
>
> I am attaching the patches.
> Does it cause any difference in the corruption in this video?
>
>     https://drive.google.com/drive/folders/0BxP5-S1t9VEEbkR4dWhTUFozV2s
>

Hi, it seems mpv and ffmpeg have been changing their vaapi code recently.

With an old mpv the corruption is the same as without the patches.

With git mpv the patches cause a segfault -

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff10bbe8e in __memcpy_sse2_unaligned () from /lib/libc.so.6
(gdb) bt
#0  0x00007ffff10bbe8e in __memcpy_sse2_unaligned () from /lib/libc.so.6
#1  0x00007fffe423f4e0 in ruvd_decode_bitstream (decoder=0x226dcb0, 
target=<optimized out>, picture=<optimized out>, num_buffers=<optimized 
out>, buffers=<optimized out>, sizes=<optimized out>) at radeon_uvd.c:1029
#2  0x00007fffe40f37cb in handleVASliceDataBufferType (buf=<optimized 
out>, context=0x2236290) at picture.c:323
#3  vlVaRenderPicture (ctx=<optimized out>, context_id=<optimized out>, 
buffers=<optimized out>, num_buffers=<optimized out>) at picture.c:518
#4  0x0000000000cba28e in ff_vaapi_decode_issue ()
#5  0x00000000008f8dac in vaapi_mpeg2_end_frame ()
#6  0x00000000007635cc in decode_chunks ()
#7  0x00000000007648e7 in mpeg_decode_frame ()
#8  0x00000000008daa53 in avcodec_decode_video2 ()
#9  0x00000000008db780 in do_decode ()
#10 0x00000000008dc650 in avcodec_send_packet ()