[Mesa-dev] [PATCH 3/3] spirv: add support for Int64 capability

Jason Ekstrand jason at jlekstrand.net
Wed Feb 15 05:41:31 UTC 2017


It's entirely possible something important is missing but I don't see
anything wrong off-hand.  All three are

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

Are there CTS tests for this?

On Feb 14, 2017 8:55 PM, "Dave Airlie" <airlied at gmail.com> wrote:

> From: Dave Airlie <airlied at redhat.com>
>
> This just adds the support at the spirv->nir level for the Int64
> cap.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/compiler/spirv/nir_spirv.h    | 1 +
>  src/compiler/spirv/spirv_to_nir.c | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/compiler/spirv/nir_spirv.h b/src/compiler/spirv/nir_
> spirv.h
> index e43e9b5..34cb5a5 100644
> --- a/src/compiler/spirv/nir_spirv.h
> +++ b/src/compiler/spirv/nir_spirv.h
> @@ -50,6 +50,7 @@ struct nir_spirv_supported_extensions {
>     bool tessellation;
>     bool draw_parameters;
>     bool image_write_without_format;
> +   bool int64;
>  };
>
>  nir_function *spirv_to_nir(const uint32_t *words, size_t word_count,
> diff --git a/src/compiler/spirv/spirv_to_nir.c
> b/src/compiler/spirv/spirv_to_nir.c
> index 7bd32ab..07a33ea 100644
> --- a/src/compiler/spirv/spirv_to_nir.c
> +++ b/src/compiler/spirv/spirv_to_nir.c
> @@ -2669,7 +2669,6 @@ vtn_handle_preamble_instruction(struct vtn_builder
> *b, SpvOp opcode,
>        case SpvCapabilityVector16:
>        case SpvCapabilityFloat16Buffer:
>        case SpvCapabilityFloat16:
> -      case SpvCapabilityInt64:
>        case SpvCapabilityInt64Atomics:
>        case SpvCapabilityAtomicStorage:
>        case SpvCapabilityInt16:
> @@ -2687,6 +2686,9 @@ vtn_handle_preamble_instruction(struct vtn_builder
> *b, SpvOp opcode,
>        case SpvCapabilityFloat64:
>           spv_check_supported(float64, cap);
>           break;
> +      case SpvCapabilityInt64:
> +         spv_check_supported(int64, cap);
> +         break;
>
>        case SpvCapabilityAddresses:
>        case SpvCapabilityKernel:
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170214/931a5870/attachment.html>


More information about the mesa-dev mailing list