[Mesa-dev] [PATCH 3/3] r100: use correct libdrm_radeon macro

[Emil Velikov]

On 14 February 2017 at 08:28, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> On 14.02.2017 02:15, Emil Velikov wrote:
>>
>> Remove local definition of RADEON_INFO_TILE_CONFIG and use the correct
>> macro provided by libdrm_radeon RADEON_INFO_TILING_CONFIG.
>>
>> Latter was present as of libdrm 2.4.22, sirca 2010.
>>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>  src/mesa/drivers/dri/radeon/radeon_screen.c | 8 ++------
>>  1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/radeon/radeon_screen.c
>> b/src/mesa/drivers/dri/radeon/radeon_screen.c
>> index 9a07535155..06901348a3 100644
>> --- a/src/mesa/drivers/dri/radeon/radeon_screen.c
>> +++ b/src/mesa/drivers/dri/radeon/radeon_screen.c
>> @@ -128,10 +128,6 @@ DRI_CONF_END
>>  };
>>  #endif
>>
>> -#ifndef RADEON_INFO_TILE_CONFIG
>> -#define RADEON_INFO_TILE_CONFIG 0x6
>> -#endif
>> -
>>  static int
>>  radeonGetParam(__DRIscreen *sPriv, int param, void *value)
>>  {
>> @@ -148,8 +144,8 @@ radeonGetParam(__DRIscreen *sPriv, int param, void
>> *value)
>>    case RADEON_PARAM_NUM_Z_PIPES:
>>      info.request = RADEON_INFO_NUM_Z_PIPES;
>>      break;
>> -  case RADEON_INFO_TILE_CONFIG:
>> -    info.request = RADEON_INFO_TILE_CONFIG;
>> +  case RADEON_INFO_TILING_CONFIG:
>> +    info.request = RADEON_INFO_TILING_CONFIG;
>>      break;
>>    default:
>>      return -EINVAL;
>>
>
> Hmm, this doesn't seem to be actually used anywhere. Then again, why not
> leave cleaning this up to somebody who actually still has the hardware...
>
Agreed.

> Series is:
>
> Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
>
Thanks !
Emil