[Mesa-dev] [PATCH 1/2] i965: Enable predicate support on gen >= 8.

Kenneth Graunke kenneth at whitecape.org
Thu Jan 5 19:29:39 UTC 2017


Predication needs cmd parser only on gen7. For newer platforms, it
should be available without it.

Signed-off-by: Rafael Antognolli <rafael.antognolli at intel.com>
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/intel_screen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Rafael,

Your patch 1 looked good, but Iago and I churned everything before
landing it. :(  Sorry!  Here's a couple of replacement patches.
I'm happy to assign authorship to you on this patch, if you like -
you're the one that caught this issue, so you should get the credit.
I just didn't want to forge it without your OK :)

 --Ken

diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c
index c79268f71b3..5fcb5c6fd7f 100644
--- a/src/mesa/drivers/dri/i965/intel_screen.c
+++ b/src/mesa/drivers/dri/i965/intel_screen.c
@@ -1773,7 +1773,7 @@ __DRIconfig **intelInitScreen2(__DRIscreen *dri_screen)
       screen->cmd_parser_version = 0;
    }
 
-   if (screen->cmd_parser_version >= 2)
+   if (screen->devinfo.gen >= 8 || screen->cmd_parser_version >= 2)
       screen->kernel_features |= KERNEL_ALLOWS_PREDICATE_WRITES;
 
    /* Haswell requires command parser version 4 in order to have L3
-- 
2.11.0



More information about the mesa-dev mailing list