[Mesa-dev] [PATCH 2/5] st/nine: Remove all usage of ureg_SUB in nine_ff

Marek Olšák maraeo at gmail.com
Fri Jan 6 16:26:11 UTC 2017


On Fri, Jan 6, 2017 at 12:43 PM, Jose Fonseca <jfonseca at vmware.com> wrote:
> I think this is a good idea.
>
> We still use them but I'm happy to see them go
>
> It would be much easier for you and for us if you just implemented a
> ureg_ABS() / ureg_SUB inline helper that would call ureg_MOV/ureg_ADD
> internally:  fewer chances of a typo somewhere, and less work necessary all
> around.

Yeah probably. A lot of the users don't use ureg, so the chances of a
typo are still pretty high.

Marek


More information about the mesa-dev mailing list