[Mesa-dev] [PATCH] glsl: Do not allow scalar types in vector relational functions

[Matt Turner]

On Mon, Jan 9, 2017 at 6:34 AM, Boyan Ding <boyan.j.ding at gmail.com> wrote:
> 2016-11-23 21:20 GMT+08:00 Boyan Ding <boyan.j.ding at gmail.com>:
>> 2016-11-07 20:27 GMT+08:00 Boyan Ding <boyan.j.ding at gmail.com>:
>>> 2016-11-05 3:23 GMT+08:00 Matt Turner <mattst88 at gmail.com>:
>>>> On Sun, Oct 30, 2016 at 11:45 PM, Boyan Ding <boyan.j.ding at gmail.com> wrote:
>>>>> According to OpenGL Shading Language 4.50 spec, Section 8.7 "Vector
>>>>> Relational Functions", functions of this type do not operate on scalar
>>>>> types, so remove scalar types from signature definitions to make the
>>>>> behavior consistent with glslangValidator and other drivers.
>>>>
>>>> Yep. Looks like it's always been this way.
>>>>
>>>> The patch is
>>>>
>>>> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>>>>
>>>> Since this seems to be untested by any suite, could you provide some
>>>> piglit parser tests that confirm that lessThanEqual(scalar, scalar),
>>>> et al doesn't work?
>>>>
>>
>> Ping? And also for the piglit patch at
>> https://lists.freedesktop.org/archives/piglit/2016-November/021350.html
>>
>> Regards,
>> Boyan Ding
>
> Yet another ping...

Oops. Sorry. I'll handle this today. Thanks for the reminder.