[Mesa-dev] [PATCH] radv: fix multi-viewport emission

[Bas Nieuwenhuizen]

Yeah, the set reg was clearly for all the regs at once.

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Tue, Jan 10, 2017 at 5:50 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This set context req seq was in the wrong place.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/si_cmd_buffer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
> index 15e520a..19dd063 100644
> --- a/src/amd/vulkan/si_cmd_buffer.c
> +++ b/src/amd/vulkan/si_cmd_buffer.c
> @@ -480,11 +480,11 @@ si_write_viewport(struct radeon_winsys_cs *cs, int first_vp,
>                 radeon_emit(cs, fui(translate[2]));
>         }
>
> +       radeon_set_context_reg_seq(cs, R_0282D0_PA_SC_VPORT_ZMIN_0 +
> +                                  first_vp * 4 * 2, count * 2);
>         for (i = 0; i < count; i++) {
>                 float zmin = MIN2(viewports[i].minDepth, viewports[i].maxDepth);
>                 float zmax = MAX2(viewports[i].minDepth, viewports[i].maxDepth);
> -               radeon_set_context_reg_seq(cs, R_0282D0_PA_SC_VPORT_ZMIN_0 +
> -                                          first_vp * 4 * 2, count * 2);
>                 radeon_emit(cs, fui(zmin));
>                 radeon_emit(cs, fui(zmax));
>         }
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev