[Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

[Emil Velikov]

On 10 January 2017 at 15:04, Vedran Miletić <vedran at miletic.net> wrote:
> On 09/19/2016 08:39 PM, Vedran Miletić wrote:
>> On 09/07/2016 06:52 PM, Vedran Miletić wrote:
>>> LLVM and Mesa both define the DEBUG macro in incompatible ways. As a
>>> general practice, we should avoid using such generic names when it is
>>> possible to do so.
>>>
>>> This patch renames all occurrences of the DEBUG macro to MESA_DEBUG,
>>> and removes workarounds previously used to enable building Mesa with
>>> LLVM (pop_macro() and push_macro() function calls).
>>>
>>> v2:
>>>  * Rename remaining occurences found by git grep '\<DEBUG\>'
>>>  * Use /* !MESA_DEBUG */ with #else instead of /* MESA_DEBUG */
>>>
>>> Signed-off-by: Vedran Miletić <vedran at miletic.net>
>>> Acked-by: Christian König <christian.koenig at amd.com>
>>> ---
>>
>> Anyone?
>>
>> Regards,
>> Vedran
>>
>
> Emil and others,
>
> I can rebase this if there would be interest in getting it merged for 17.0.
>
Thanks for the reminder.

Not meaning to flock a dead horse - I'm rarely keen adding workarounds
and this looks like one.
Then again consider me neutral on the topic and I'll leave the final
call to Brian.

-Emil