[Mesa-dev] [PATCH 03/11] i965/vec4: use attribute slots for first non payload GRF

[Jordan Justen]

On 2017-01-09 09:10:01, Juan A. Suarez Romero wrote:
> From: Alejandro Piñeiro <apinheiro at igalia.com>
> 
> ---
>  src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> index 5ddbe58..f80162d 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> @@ -1757,7 +1757,7 @@ vec4_vs_visitor::setup_attributes(int payload_reg)
>  
>     lower_attributes_to_hw_regs(attribute_map, false /* interleaved */);
>  
> -   return payload_reg + vs_prog_data->nr_attributes;
> +   return payload_reg + vs_prog_data->nr_attribute_slots;

This path will be hit by gen >= 8, right? Can you explain why it is
needed for gen < 8, and if appropriate, why it is okay for gen >= 8?

The explanation could be something that you can then add to the commit
message...

Thanks,

-Jordan