[Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

Randy Xu randy.xu at intel.com
Wed Jan 11 08:04:03 UTC 2017


On Android platform, the EGL configuration query (eglGetConfigs) will
check the DRI backend. Add R8G8B8A8 and R8G8B8X8 to meet the native app
test requirement (like gl2_basic etc.).

Reorder the list and move the B5G6R5 to the tail, it can solve two dEQP
failures on Android platform, they are dEQP-GLES3.functional.fragment_ops.
blend.default_framebuffer.rgb_func_alpha_func.src.dst_color_one_minus_dst_alpha
& .dst_color_constant_alpha. These two failures are all caused by B5G6R5 low
precision and the dEQP case always choose the first EGL configure id in list
returned by eglGetConfigs. The failure cannot be reproduced on X11 platform as
Intel does not support 16bit visuals with X driver

Signed-off-by: Randy Xu <randy.xu at intel.com>
---
 src/mesa/drivers/dri/i965/intel_screen.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c
index e1c3c19..d55db27 100644
--- a/src/mesa/drivers/dri/i965/intel_screen.c
+++ b/src/mesa/drivers/dri/i965/intel_screen.c
@@ -1298,9 +1298,11 @@ static __DRIconfig**
 intel_screen_make_configs(__DRIscreen *dri_screen)
 {
    static const mesa_format formats[] = {
-      MESA_FORMAT_B5G6R5_UNORM,
+      MESA_FORMAT_R8G8B8A8_UNORM,
+      MESA_FORMAT_R8G8B8X8_UNORM,
       MESA_FORMAT_B8G8R8A8_UNORM,
       MESA_FORMAT_B8G8R8X8_UNORM
+      MESA_FORMAT_B5G6R5_UNORM,
    };
 
    /* GLX_SWAP_COPY_OML is not supported due to page flipping. */
-- 
2.7.4



More information about the mesa-dev mailing list