[Mesa-dev] [PATCH 03/11] i965/vec4: use attribute slots for first non payload GRF

[Jordan Justen]

On 2017-01-11 02:33:59, Alejandro Piñeiro wrote:
> On 10/01/17 15:52, Jordan Justen wrote:
> > The explanation could be something that you can then add to the commit
> > message...
> 
> Ok, so how about a commit message like this?:
> 
> "i965/vec4: use attribute slots for first non payload GRF
> 
> As part of the payload setup, setup_attributes is called with the first
> GRF that can be used for the attributes (first ones are used for
> uniforms for example) and returns the first GRF that is not part of the
> payload. Before this patch, it adds directly the number of attributes.
> But as with 64-bit attributes can consume more than one slot, that is
> not valid anymore. This patch change the addition to use the number of
> slots consumed.
> 
> gen >= 8 would not be affected, as they use the scalar mode. For that
> case, the vs configuration is done at fs_visitor::assign_vs_urb_setup."

Sound good. Thanks!

Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>