[Mesa-dev] [PATCH 20/22] anv/blorp: Don't fast depth clear samplable HiZ buffers on BDW

[Jason Ekstrand]

On Wed, Jan 11, 2017 at 5:55 PM, Nanley Chery <nanleychery at gmail.com> wrote:

> Avoid the resolves that would be required if fast depth clears were
> allowed for such buffers.
>
> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>  src/intel/vulkan/anv_blorp.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
> index 5d410f7d86..4649ffd9db 100644
> --- a/src/intel/vulkan/anv_blorp.c
> +++ b/src/intel/vulkan/anv_blorp.c
> @@ -1270,6 +1270,15 @@ anv_cmd_buffer_clear_subpass(struct anv_cmd_buffer
> *cmd_buffer)
>                  * ANV_HZ_FC_VAL.
>                  */
>                 clear_with_hiz = false;
> +            } else if (gen == 8 &&
> +                       anv_can_sample_with_hiz(cmd_
> buffer->device->info.gen,
> +                                               iview->image->samples)) {
> +               /* Only gen9+ supports returning ANV_HZ_FC_VAL when
> sampling a
> +                * fast-cleared portion of a HiZ buffer. Testing has
> revealed
> +                * that Gen8 only supports returning 0.0f. Gens prior to
> gen8 do
> +                * not support this feature at all.
> +                */
> +               clear_with_hiz = false;
>

Doesn't this mean that we should use a clear value of 0 on BDW and 1 on
SKL+?  I'm confused by this comment.


>              }
>           }
>
> --
> 2.11.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170111/3470efa0/attachment.html>