[Mesa-dev] [PATCH] nir/i965: assert first is always less than 64

Iago Toral itoral at igalia.com
Thu Jan 12 13:41:05 UTC 2017


Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

On Thu, 2017-01-12 at 12:24 +0100, Juan A. Suarez Romero wrote:
> This fixes a defect detected by Coverity Scan.
> ---
>  src/mesa/drivers/dri/i965/brw_draw_upload.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c
> b/src/mesa/drivers/dri/i965/brw_draw_upload.c
> index b7527f2cd9..abf3859614 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw_upload.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c
> @@ -482,6 +482,7 @@ brw_prepare_vertices(struct brw_context *brw)
>     brw->vb.nr_enabled = 0;
>     while (vs_inputs) {
>        GLuint first = ffsll(vs_inputs) - 1;
> +      assert (first < 64);
>        GLuint index =
>           first - DIV_ROUND_UP(_mesa_bitcount_64(vs_prog_data-
> >double_inputs_read &
>                                                  BITFIELD64_MASK(firs
> t)), 2);


More information about the mesa-dev mailing list