[Mesa-dev] [PATCH v2 0/9] radeonsi, radv: fix cube map coordinate derivatives

Nicolai Hähnle nhaehnle at gmail.com
Thu Jan 12 15:39:26 UTC 2017


Hi all,

once more without the change to the offset, and with a small fix on
patch #5: while munging radv and radeonsi versions of prepare_cube_coords
together, I accidentally went back to touching all four coordinates.
This is fixed now.

With Bas' testing on radv and more thorough piglit/cts testing on
radeonsi, this looks correct now. I admit I still don't understand
understand the 0.5 vs. 1.5 offset issue, but (a) we now stick to the
magic 1.5 that was used before, (b) the tests look good, and (c) I'd
like to land this for 17.0, so...

Thanks,
Nicolai



More information about the mesa-dev mailing list