[Mesa-dev] [Mesa-stable] [PATCH] mesa/main: fix version/extension checks in _mesa_ClampColor

[Ilia Mirkin]

On Thu, Jan 12, 2017 at 11:39 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 12 January 2017 at 09:55, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>
>> Add a proper check for feature support, and raise an invalid enum for
>> GL_CLAMP_VERTEX/FRAGMENT_COLOR unconditionally in core profiles, since
>> those enums were explicitly removed after the extension was promoted
>> to core functionality (not in the profile sense) with OpenGL 3.0.
>>
> Wouldn't it be better to simply not advertise the extension for Core profiles ?

I'm fine with either approach FWIW. My initial comments were based on
the theory that the ext enabled clamping in core contexts, but that
doesn't sound like it's the case.

Could be more straightforward to just flip the ext to be GLL instead.

Cheers,

  -ilia