[Mesa-dev] [PATCH v2 3/4] anv: generate entry points from vk.xml

[Lionel Landwerlin]

On 13/01/17 14:31, Emil Velikov wrote:
> On 13 January 2017 at 12:00, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> v2: rework entry point iteration (Jason)
>>      cleanup unused imports
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> ---
>>   src/intel/vulkan/Makefile.am            |  15 ++--
>>   src/intel/vulkan/anv_entrypoints_gen.py | 126 ++++++++++++++++----------------
>>   2 files changed, 71 insertions(+), 70 deletions(-)
>>
>> diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am
>> index df7645fb13..d32b57f267 100644
>> --- a/src/intel/vulkan/Makefile.am
>> +++ b/src/intel/vulkan/Makefile.am
>> @@ -23,11 +23,6 @@ include Makefile.sources
>>
>>   vulkan_includedir = $(includedir)/vulkan
>>
>> -vulkan_include_HEADERS = \
>> -       $(top_srcdir)/include/vulkan/vk_platform.h \
>> -       $(top_srcdir)/include/vulkan/vulkan.h \
>> -       $(top_srcdir)/include/vulkan/vulkan_intel.h
>> -
> I think that in the long term we might want to remove the local
> headers/xml files and use the Khronos ones directly. Distros, Arch at
> least, already ship them in separate package.
>
> Until then we really want to keep the above hunk. vulkan_intel.h must
> always be there - Mesa is the canonical source of it, afaict.

But they're not a dependency to build the entry point files anymore with 
these 2 patches.
So why have them as a dependency?


>
> With this and same fix for 4/4, the build parts of the series
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>
> Thanks
> Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev