[Mesa-dev] [PATCH v2 3/4] anv: generate entry points from vk.xml

[Jason Ekstrand]

On Jan 13, 2017 7:22 AM, "Emil Velikov" <emil.l.velikov at gmail.com> wrote:

On 13 January 2017 at 15:02, Lionel Landwerlin
<lionel.g.landwerlin at intel.com> wrote:
> On 13/01/17 14:31, Emil Velikov wrote:
>>
>> On 13 January 2017 at 12:00, Lionel Landwerlin
>> <lionel.g.landwerlin at intel.com> wrote:
>>>
>>> v2: rework entry point iteration (Jason)
>>>      cleanup unused imports
>>>
>>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>>> ---
>>>   src/intel/vulkan/Makefile.am            |  15 ++--
>>>   src/intel/vulkan/anv_entrypoints_gen.py | 126
>>> ++++++++++++++++----------------
>>>   2 files changed, 71 insertions(+), 70 deletions(-)
>>>
>>> diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am
>>> index df7645fb13..d32b57f267 100644
>>> --- a/src/intel/vulkan/Makefile.am
>>> +++ b/src/intel/vulkan/Makefile.am
>>> @@ -23,11 +23,6 @@ include Makefile.sources
>>>
>>>   vulkan_includedir = $(includedir)/vulkan
>>>
>>> -vulkan_include_HEADERS = \
>>> -       $(top_srcdir)/include/vulkan/vk_platform.h \
>>> -       $(top_srcdir)/include/vulkan/vulkan.h \
>>> -       $(top_srcdir)/include/vulkan/vulkan_intel.h
>>> -
>>
>> I think that in the long term we might want to remove the local
>> headers/xml files and use the Khronos ones directly. Distros, Arch at
>> least, already ship them in separate package.


So does Fedora.  They get installed as part of vulkan-devel which is the
dev package for the loader.

>> Until then we really want to keep the above hunk. vulkan_intel.h must
>> always be there - Mesa is the canonical source of it, afaict.


Yes, we want to keep the vulkan_intel.h part but should probably drop the
rest eventually.

> But they're not a dependency to build the entry point files anymore with
> these 2 patches.
> So why have them as a dependency?
>
You've already handled dependency tracking nicely in the now missing hunk.
The above 4-5 lines install the headers.


Thanks for catching that.  I think we do want to drop installing everything
except vulkan_intel.h but it should be a separate patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170113/fe78bd6f/attachment-0001.html>