[Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

[Andy Furniss]

Nayan Deshmukh wrote:
> On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss <adf.lists at gmail.com> wrote:
>
>> Nayan Deshmukh wrote:
>>
>>> Hi Andy,
>>>
>>> Please test this patch for regressions.
>>>
>>
>> Do you have a testcase to show the fix?
>>
>> TBH I've not tested gstreamer with mpeg2 before as vaapi mpeg2
>> h/w dec never worked properly anyway.
>>
>> https://bugs.freedesktop.org/show_bug.cgi?id=93760
>>
>> With mpv --hwdec=vaapi it doesn't seem to regress anything.
>>
> I was talking about --hwdec=vaapi. Before this patch I was not able to play
> any mpeg videos with vaapi as mpv --hwdec=vaapi --vo=vaapi always
> segfaulted. With this patch I can see videos properly. Just wanted to
> make sure it did not cause any regression when using hardware decoder.

Oh, OK, I can't reproduce that with mpv, but it will still just assert 
with mesa debug build

mpv: picture_mpeg12.c:84: vlVaHandleSliceParameterBufferMPEG12: 
Assertion `buf->size >= sizeof(VASliceParameterBufferMPEG2) && 
buf->num_elements == 1' failed.

Or play with non debug build, but depending on source vid may be
slightly corrupted.

Would be interesting to see if you see the same with this vid
which easily shows the corruption.

https://drive.google.com/drive/folders/0BxP5-S1t9VEEbkR4dWhTUFozV2s?usp=sharing

Looks bad --hwdec-vaapi with or without --vo=vaapi

OK with --hwdec=vdpau --vo=vdpau (just --hwdec=vdpau will be slightly wrong
currently as there is a vdpau gl interop bug that causes half res)


>> More generally - it's really good you are working on vaapi - I don't
>> know what you've discusses with anyone but did you see the old threads
>> around VAAPI_DISABLE_INTERLACE?
>>
> I haven't discussed it with anyone but I will try reading the old threads
> and the
> bug reports.

Thanks.