[Mesa-dev] Unify the style of function pointer calls in structs

Emil Velikov emil.l.velikov at gmail.com
Fri Jan 13 17:03:23 UTC 2017


Hi Boyan,

On 25 November 2015 at 05:27, Boyan Ding <boyan.j.ding at gmail.com> wrote:
> This series is a follow-up of Brian's patch ([1], commit 47fae842). It
> converts nearly all of the function-pointer-in-a-struct calls from
>   (*foo->bar)(...) or (foo->bar)(...)
> to
>   foo->bar(...)
>
> The sed regex to do the conversion looks like this (really ugly):
>   s/(\*\?\([^*(), \]]*->[^*), \]]*\))(/\1(/
> It doesn't affect pointer-to-member operation in C++ (the parenthesis
> there can't be omitted).
>
> This series didn't touch the gtest directory since it seems to be an
> external project. If people think it is also necessary to apply
> conversion there, I can send the patch for it.
>
> I compile-tested the series and it builds okay.
>
I could swear I've pushed this series ages ago... but it is now.

I've added a couple of extra fixes and pushed the lot excluding 2/8
and 8/8. Former is quite incomplete whist the latter is no longer
applicable.
According to the following grep we have another ~60 cases in glx, with
a couple of odd ones throughout.

Please let us know if some patches fall through the cracks.

Thanks
Emil


More information about the mesa-dev mailing list