[Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

[Emil Velikov]

On 13 January 2017 at 19:22, Vladislav Egorov <vegorov180 at gmail.com> wrote:
> 13.01.2017 19:51, Emil Velikov пишет:
>>
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> At the moment we support 5+ different implementations each with varying
>> amount of bugs - from thread safely problems [1], to outright broken
>> implementation(s) [2]
>>
>> In order to accommodate these we have 150+ lines of configure script and
>> extra two configure toggles. Whist an actual implementation being
>> ~200loc and our current compat wrapping ~250.
>>
>> Let's not forget that different people use different code paths, thus
>> effectively makes it harder to test and debug since the default
>> implementation is automatically detected.
>>
>> To minimise all these lovely experiences, import the "100% Public
>> Domain" OpenBSD sha1 implementation. Clearly document any changes needed
>> to get building correctly, since many/most of those can be upstreamed
>> making future syncs easier.
>
>
> It can hurt performance.
This is not performance critical path ;-) If that ever changes we can
rethink our options.

Emil