[Mesa-dev] [PATCH 11/11] anv: Enable tessellation shaders.

[Kenneth Graunke]

On Thursday, January 12, 2017 1:41:10 PM PST Eero Tamminen wrote:
> Hi,
> 
> On 11.01.2017 20:07, Lionel Landwerlin wrote:
> > On 11/01/17 17:02, Eero Tamminen wrote:
> >> On 09.01.2017 07:26, Kenneth Graunke wrote:
> >>> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> >>> ---
> >>>  src/intel/vulkan/anv_device.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> I'm not clear whether we want to do this yet.
> >>>
> >>> On Skylake, the status is: 99.3% of the CTS passing, Sascha demos work.
> >>
> >> Tested on SKL GT2, now that this is in...
> >>
> >> Sascha's displacement mapping and PN-triangles tessellation demos work
> >> now fine, but with terrain tessellation test I get:
> >> ------------------
> >> DL(ERROR): object: 0x0 type: 2 location: 4198 msgCode: 5: While
> >> calling vkCreateDevice(), requesting feature #24 in
> >> VkPhysicalDeviceFeatures struct, which is not available on this device.
> >> DL(ERROR): object: 0x0 type: 2 location: 4209 msgCode: 5: You
> >> requested features that are unavailable on this device. You should
> >> first query feature availability by calling
> >> vkGetPhysicalDeviceFeatures().
> >> ...
> >> Fatal : VkResult is "ERROR_INCOMPATIBLE_DRIVER" in
> >> /home/testrunner/work/VulkanSachaWillems/terraintessellation/terraintessellation.cpp
> >> at line 193
> >> terraintessellation:
> >> /home/testrunner/work/VulkanSachaWillems/terraintessellation/terraintessellation.cpp:193:
> >> void VulkanExample::setupQueryResultBuffer(): Assertion `res ==
> >> VK_SUCCESS' failed.
> >> Aborted (core dumped)
> >> ------------------
> >>
> >> Do you have some extra stuff in Mesa or some specific branch of the
> >> demos?
> >
> > Looks like the demo is using query statistics.
> > Mind adding the following patches from Ilia :
> > https://patchwork.freedesktop.org/series/15841/ ?
> 
> Yes, with that the demo runs fine.
> 
> Now it gives only the same validation errors that all the other demos 
> output:
> ---------------------
> DS(ERROR): object: 0x11 type: 18 location: 9975 msgCode: 408: 
> vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #0 has format 
> of VK_FORMAT_B8G8R8A8_SRGB that does not match the format of 
> VK_FORMAT_B8G8R8A8_UNORM used by the corresponding attachment for 
> renderPass (0x11). For more information refer to Vulkan Spec Section 
> '7.3. Framebuffers' which states 'Any given element of pAttachments must 
> have been created with an VkFormat value that matches the VkFormat 
> specified by the corresponding VkAttachmentDescription in renderPass' 
> (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#renderpass-noattachments)
> ---------------------
> 
> 
> 	- Eero

It might work if you comment out the assertion in genX_cmd_buffer.c:

         assert(iview->vk_format == att->format);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170115/61e2a19c/attachment.sig>