[Mesa-dev] [PATCH 17/22] i965/vec4: fix register_coalesce() for partial writes

Samuel Iglesias Gonsálvez siglesias at igalia.com
Mon Jan 16 09:27:33 UTC 2017


On Mon, 2017-01-16 at 09:01 +0100, Samuel Iglesias Gonsálvez wrote:
> On Fri, 2017-01-13 at 15:46 -0800, Matt Turner wrote:
> > On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez
> > <siglesias at igalia.com> wrote:
> > > From: "Juan A. Suarez Romero" <jasuarez at igalia.com>
> > > 
> > > When lowering double_to_single() we added a final mov() that puts
> > > 32-bit
> > 
> > I can't confirm that this patch is necessary in the current
> > i965-fp64-gen7-ivb-scalar-vec4-rc2 branch. It passes Jenkins with
> > it
> > reverted.
> > 
> 
> Right. We are going to run some tests locally and see if it is
> actually
> needed.
> 

OK, it is not needed. I removed it locally.

BTW, there were no comments on patches 18 and 19. So, if you can take a
look at them to see if we need to fix them, it would be great. Our idea
is to send the v2 of the series tomorrow :-)

Thanks for all the reviews!

Sam

> Sam
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list