[Mesa-dev] [PATCH 04/27] i965/gen6: Remove check for stencil format

Samuel Iglesias Gonsálvez siglesias at igalia.com
Mon Jan 16 12:07:38 UTC 2017


On Mon, 2017-01-16 at 11:13 +0200, Topi Pohjolainen wrote:
> There are is no alternative.
> 

There is no alternative.

Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/gen6_depth_state.c | 22 ++++++++--------
> ------
>  1 file changed, 8 insertions(+), 14 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/gen6_depth_state.c
> b/src/mesa/drivers/dri/i965/gen6_depth_state.c
> index 3f14006..cb0ed25 100644
> --- a/src/mesa/drivers/dri/i965/gen6_depth_state.c
> +++ b/src/mesa/drivers/dri/i965/gen6_depth_state.c
> @@ -191,20 +191,14 @@ gen6_emit_depth_stencil_hiz(struct brw_context
> *brw,
>           uint32_t offset = 0;
>  
>           if (stencil_mt->array_layout == ALL_SLICES_AT_EACH_LOD) {
> -            if (stencil_mt->format == MESA_FORMAT_S_UINT8) {
> -               /* Note: we can't compute the stencil offset using
> -                * intel_region_get_aligned_offset(), because
> stencil_region
> -                * claims that the region is untiled even though it's
> W tiled.
> -                */
> -               offset =
> -                  stencil_mt->level[lod].level_y * stencil_mt->pitch 
> +
> -                  stencil_mt->level[lod].level_x * 64;
> -            } else {
> -               offset = intel_miptree_get_aligned_offset(
> -                           stencil_mt,
> -                           stencil_mt->level[lod].level_x,
> -                           stencil_mt->level[lod].level_y);
> -            }
> +            assert(stencil_mt->format == MESA_FORMAT_S_UINT8);
> +
> +            /* Note: we can't compute the stencil offset using
> +             * intel_region_get_aligned_offset(), because
> stencil_region
> +             * claims that the region is untiled even though it's W
> tiled.
> +             */
> +            offset = stencil_mt->level[lod].level_y * stencil_mt-
> >pitch +
> +                     stencil_mt->level[lod].level_x * 64;
>           }
>  
>  	 BEGIN_BATCH(3);


More information about the mesa-dev mailing list