[Mesa-dev] [PATCH 01/19] i965: automake: correctly set MKDIR_GEN

Kenneth Graunke kenneth at whitecape.org
Mon Jan 16 18:30:56 UTC 2017


On Monday, January 16, 2017 3:45:32 PM PST Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Otherwise we might end up w/o the respective folder (depending on
> autotools version) and fail at build time.
> 
> Fixes: bfd17c76c12 "i965: Port INTEL_PRECISE_TRIG=1 to NIR."
> Cc: "12.0 13.0" <mesa-dev at lists.freedesktop.org>
> Cc: Kenneth Graunke <kenneth at whitecape.org>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
> Worth setting in configure and/or using @MKDIR_GEN@ + AC_SUBST ?
> ---
>  src/mesa/drivers/dri/i965/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am
> index 4b009770ab..92cb5b5ba0 100644
> --- a/src/mesa/drivers/dri/i965/Makefile.am
> +++ b/src/mesa/drivers/dri/i965/Makefile.am
> @@ -45,6 +45,7 @@ AM_CFLAGS = \
>  
>  AM_CXXFLAGS = $(AM_CFLAGS)
>  
> +MKDIR_GEN = $(AM_V_at)$(MKDIR_P) $(@D)
>  brw_nir_trig_workarounds.c: brw_nir_trig_workarounds.py $(top_srcdir)/src/compiler/nir/nir_algebraic.py
>  	$(MKDIR_GEN)
>  	$(AM_V_GEN) PYTHONPATH=$(top_srcdir)/src/compiler/nir $(PYTHON2) $(PYTHON_FLAGS) $(srcdir)/brw_nir_trig_workarounds.py > $@ || ($(RM) $@; false)
> 

autotools...where making a directory requires piles of hacks... :/

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170116/9a43dbf4/attachment.sig>


More information about the mesa-dev mailing list