[Mesa-dev] [PATCH 3/7] i965: Don't map/unmap in brw_print_program_cache on LLC platforms.

[Eduardo Lima Mitev]

Reviewed-by: Eduardo Lima Mitev <elima at igalia.com>

On 01/17/2017 08:14 AM, Kenneth Graunke wrote:
> We have a persistent mapping.  Don't map it a second time or try to
> unmap it.  Just use the pointer.
> 
> This most likely would wreak havoc except that this code is unused
> (it's only called from an if (0) debug block).
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_program_cache.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c b/src/mesa/drivers/dri/i965/brw_program_cache.c
> index 8939fb110fd..44d9994de01 100644
> --- a/src/mesa/drivers/dri/i965/brw_program_cache.c
> +++ b/src/mesa/drivers/dri/i965/brw_program_cache.c
> @@ -514,7 +514,8 @@ brw_print_program_cache(struct brw_context *brw)
>     const struct brw_cache *cache = &brw->cache;
>     struct brw_cache_item *item;
>  
> -   drm_intel_bo_map(cache->bo, false);
> +   if (!brw->has_llc)
> +      drm_intel_bo_map(cache->bo, false);
>  
>     for (unsigned i = 0; i < cache->size; i++) {
>        for (item = cache->items[i]; item; item = item->next) {
> @@ -524,5 +525,6 @@ brw_print_program_cache(struct brw_context *brw)
>        }
>     }
>  
> -   drm_intel_bo_unmap(cache->bo);
> +   if (!brw->has_llc)
> +      drm_intel_bo_unmap(cache->bo);
>  }
>