[Mesa-dev] Mesa (master): st/vdpau: use dri3 to directly send the buffer to X(v2)

[Christian König]

Am 18.01.2017 um 09:25 schrieb Michel Dänzer:
> On 17/01/17 09:55 PM, Christian König wrote:
>> Module: Mesa
>> Branch: master
>> Commit: 15bfdea99c7b487d2c38d6dd7b88fb44810ef75a
>> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=15bfdea99c7b487d2c38d6dd7b88fb44810ef75a
>>
>> Author: Nayan Deshmukh <nayan26deshmukh at gmail.com>
>> Date:   Wed Jan 11 22:45:14 2017 +0530
>>
>> st/vdpau: use dri3 to directly send the buffer to X(v2)
> Unfortunately, this broke VLC, resulting in incorrect colours in videos.
> The problem is that VDP_RGBA_FORMAT_R10G10B10A2 is passed to
> vlVdpOutputSurfaceCreate. This can't work directly for presentation,
> because the Present extension request PresentPixmap only works if the
> pixmap depth matches the window depth, otherwise it returns a BadMatch
> protocol error.

Price question: Is that a general limitation or just something not 
implemented?

Would be bad if we force the application to use a certain format for the 
backing buffer just because X can't handle it.

>
> vlVdpOutputSurfaceCreate needs to check that the format passed in
> matches the window (surface?) format, and fall back to the old method
> otherwise.
>
> If this takes significant effort, maybe just revert the commit for now.

Thanks for the heads up.

If Nayan can't fix this in a proper time frame I will just revert the 
patches for now.

Christian.