[Mesa-dev] Mesa (master): st/vdpau: use dri3 to directly send the buffer to X(v2)

[Christian König]

> Christian, I was wondering if removing the rendering hack is right since
> with this vlc will follow the old codepath even with dri3.  Should we revert
> that commit?
No, that VLC tries to use 10bit channels on an 8bit X display is the 
problem here.

Even if we fix the X extension to allow that, we would end up with an 
extra copy to display the result.

If you make the extra copy on the client side or if you make the extra 
copy on the X side doesn't make much difference.

Regards,
Christian.

Am 18.01.2017 um 15:47 schrieb Nayan Deshmukh:
> I could simply add an extra parameter to vlVdpOutputSurface which shows
> that window and surface have the same format and revert to older otherwise.
>
> Christian, I was wondering if removing the rendering hack is right since
> with this vlc will follow the old codepath even with dri3.  Should we revert
> that commit?
>
> Regards,
> Nayan
> On Wed, Jan 18, 2017 at 3:26 PM, Michel Dänzer <michel at daenzer.net> wrote:
>> On 18/01/17 06:47 PM, Christian König wrote:
>>> Am 18.01.2017 um 09:25 schrieb Michel Dänzer:
>>>> On 17/01/17 09:55 PM, Christian König wrote:
>>>>> Module: Mesa
>>>>> Branch: master
>>>>> Commit: 15bfdea99c7b487d2c38d6dd7b88fb44810ef75a
>>>>> URL:
>>>>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=15bfdea99c7b487d2c38d6dd7b88fb44810ef75a
>>>>>
>>>>>
>>>>> Author: Nayan Deshmukh <nayan26deshmukh at gmail.com>
>>>>> Date:   Wed Jan 11 22:45:14 2017 +0530
>>>>>
>>>>> st/vdpau: use dri3 to directly send the buffer to X(v2)
>>>> Unfortunately, this broke VLC, resulting in incorrect colours in videos.
>>>> The problem is that VDP_RGBA_FORMAT_R10G10B10A2 is passed to
>>>> vlVdpOutputSurfaceCreate. This can't work directly for presentation,
>>>> because the Present extension request PresentPixmap only works if the
>>>> pixmap depth matches the window depth, otherwise it returns a BadMatch
>>>> protocol error.
>>> Price question: Is that a general limitation or just something not
>>> implemented?
>> The former. This would require adding a new Present extension request
>> for cases where the depths of the source pixmap and the destination
>> window don't match.
>>
>>
>> --
>> Earthling Michel Dänzer               |               http://www.amd.com
>> Libre software enthusiast             |             Mesa and X developer