[Mesa-dev] [PATCH 8/8] configure.ac: correctly manage llvm auto-detection

Tobias Droste tdroste at gmx.de
Wed Jan 18 18:12:05 UTC 2017


Reviewed-by: Tobias Droste <tdroste at gmx.de>

Am Mittwoch, 18. Januar 2017, 13:54:04 CET schrieb Emil Velikov:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Earlier refactoring commits changed from one, dare I say it, broken
> behaviour to another. Namely:
> 
> Before, as you explicitly enable gallium-llvm your selection was ignored
> when llvm-config was not present/detected.
> Today, the "auto" heuristics enables gallium-llvm regardless if you have
> llvm/llvm-config available or not.
> 
> Rework the latter to attribute for llvm's presence.
> 
> Cc: Tobias Droste <tdroste at gmx.de>
> Cc: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> Reported-bY: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index e21041434f..5a42a8ca83 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2325,7 +2325,7 @@ AC_ARG_ENABLE([gallium-llvm],
>  if test -z "$with_gallium_drivers"; then
>      enable_gallium_llvm=no
>  fi
> -if test "x$enable_gallium_llvm" = xauto; then
> +if test "x$enable_gallium_llvm" = xauto -a "x$FOUND_LLVM" = xyes; then
>      case "$host_cpu" in
>      i*86|x86_64|amd64) enable_gallium_llvm=yes;;
>      *) enable_gallium_llvm=no;;


More information about the mesa-dev mailing list