[Mesa-dev] [AppVeyor] mesa master #3186 failed

[Emil Velikov]

On 18 January 2017 at 19:13, AppVeyor <no-reply at appveyor.com> wrote:
> Build mesa 3186 failed
>
> Commit d1efa09d34 by Emil Velikov on 1/13/2017 4:51 PM:
> util: import sha1 implementation from OpenBSD\n\nAt the moment we support 5+
> different implementations each with varying\namount of bugs - from thread
> safely problems [1], to outright broken\nimplementation(s) [2]\n\nIn order
> to accommodate these we have 150+ lines of configure script and\nextra two
> configure toggles. Whist an actual implementation being\n~200loc and our
> current compat wrapping ~250.\n\nLet's not forget that different people use
> different code paths, thus\neffectively makes it harder to test and debug
> since the default\nimplementation is automatically detected.\n\nTo minimise
> all these lovely experiences, import the "100% Public\nDomain" OpenBSD sha1
> implementation. Clearly document any changes needed\nto get building
> correctly, since many/most of those can be upstreamed\nmaking future syncs
> easier.\n\nAs an added bonus this will avoid all the 'fun' experiences
> trying to\nintegrate it with the Android and SCons builds.\n\nv2: Manually
> expand __BEGIN_DECLS/__END_DECLS and document (Tapani).\n\nFurthermore it
> seems that some games (or surrounding runtime) static\nlink against OpenSSL
> resulting in conflicts. For more information see\nthe discussion thread
> [3]\n\nBugzilla [1]:
> https://bugs.freedesktop.org/show_bug.cgi?id=94904\nBugzilla [2]:
> https://bugs.freedesktop.org/show_bug.cgi?id=97967\n[3]
> https://lists.freedesktop.org/archives/mesa-dev/2017-January/140748.html\nCc:
> Mark Janes <mark.a.janes at intel.com>\nCc: Vinson Lee
> <vlee at freedesktop.org>\nCc: Tapani Pälli <tapani.palli at intel.com>\nCc:
> Jonathan Gray <jsg at jsg.id.au>\nTested-by: Jonathan Gray
> <jsg at jsg.id.au>\nSigned-off-by: Emil Velikov
> <emil.velikov at collabora.com>\nAcked-by: Tapani Pälli
> <tapani.palli at intel.com> (v1)\nAcked-by: Jason Ekstrand
> <jason at jlekstrand.net> (v1)
>
Could swear Appveyour gave a clean bill of health. I'm looking at it atm.
If it doesn't pan out - I'll restrict this to only Linux/Android.

Emil