[Mesa-dev] [PATCH v2] st/vdpau: only send buffers with B8G8R8A8 format to X

Michel Dänzer michel at daenzer.net
Thu Jan 19 06:45:07 UTC 2017


On 19/01/17 02:10 PM, Nayan Deshmukh wrote:
> PresentPixmap only works if the pixmap depth and format matches
> with the window, otherwise it returns a BadMatch protocol error.

Nitpick: PresentPixmap only returns BadMatch if the depths don't match.
It doesn't know anything about formats, so if the VDPAU format doesn't
match the window visual, PresentPixmap will "work" but the result will
have incorrect colours.


Other than that, looks good to me.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the mesa-dev mailing list