[Mesa-dev] [PATCH v2 05/20] i965: Use <0, 2, 1> region for scalar DF sources on IVB/BYT.

[Samuel Iglesias Gonsálvez]

On Wed, 2017-01-18 at 11:39 -0800, Matt Turner wrote:
> On Wed, Jan 18, 2017 at 2:45 AM, Samuel Iglesias Gonsálvez
> <siglesias at igalia.com> wrote:
> > On Tue, 2017-01-17 at 13:33 -0800, Francisco Jerez wrote:
> > > Samuel Iglesias Gonsálvez <siglesias at igalia.com> writes:
> > > 
> > > > From: Matt Turner <mattst88 at gmail.com>
> > > > 
> > > > On HSW+, scalar DF sources can be accessed using the normal
> > > > <0,1,0>
> > > > region, but on IVB and BYT DF regions must be programmed in
> > > > terms
> > > > of
> > > > floats. A <0,2,1> region accomplishes this.
> > > 
> > > Any reason you're doing this here twice instead of during fs_reg
> > > to
> > > brw_reg conversion?
> > > 
> > 
> > I have modified locally this patch to do it in
> > brw_reg_from_fs_reg().
> > Matt, if you agree with Curro's suggestion, I can keep the new
> > version
> > in my branch instead of this.
> 
> I found your patch. Looks good to me.
> 
> I just have one request: order the comparisons and assignments as
> vstride, width, hstride -- the same way they appear in the <V,W,H>
> regioning notation.
> 

OK, thanks Matt.

Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170119/37247ddf/attachment.sig>