[Mesa-dev] [PATCH] nir/algebraic: Only include nir_search_helpers once

Iago Toral itoral at igalia.com
Thu Jan 19 07:37:01 UTC 2017


Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

On Wed, 2017-01-18 at 15:24 -0800, Jason Ekstrand wrote:
> We were including it once per value, so probably around 10k times.
> Let's not cause the compiler any more work than we have to.
> ---
>  src/compiler/nir/nir_algebraic.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/nir/nir_algebraic.py
> b/src/compiler/nir/nir_algebraic.py
> index b0fa9e7..8c7fbc8 100644
> --- a/src/compiler/nir/nir_algebraic.py
> +++ b/src/compiler/nir/nir_algebraic.py
> @@ -76,7 +76,6 @@ class Value(object):
>           return Constant(val, name_base)
>  
>     __template = mako.template.Template("""
> -#include "compiler/nir/nir_search_helpers.h"
>  static const ${val.c_type} ${val.name} = {
>     { ${val.type_enum}, ${val.bit_size} },
>  % if isinstance(val, Constant):
> @@ -500,6 +499,7 @@ class SearchAndReplace(object):
>  _algebraic_pass_template = mako.template.Template("""
>  #include "nir.h"
>  #include "nir_search.h"
> +#include "nir_search_helpers.h"
>  
>  #ifndef NIR_OPT_ALGEBRAIC_STRUCT_DEFS
>  #define NIR_OPT_ALGEBRAIC_STRUCT_DEFS


More information about the mesa-dev mailing list