[Mesa-dev] [PATCH] gallivm: use #ifdef not #if for PIPE_ARCH_BIG_ENDIAN

Emil Velikov emil.l.velikov at gmail.com
Thu Jan 19 15:52:06 UTC 2017


On 19 January 2017 at 05:23, Roland Scheidegger <sroland at vmware.com> wrote:
> Am 19.01.2017 um 05:40 schrieb Dave Airlie:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> This fixes the build on ppc/s390.
>>
>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>> ---
>>  src/gallium/auxiliary/gallivm/lp_bld_gather.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_gather.c b/src/gallium/auxiliary/gallivm/lp_bld_gather.c
>> index 7654ba0..807baf1 100644
>> --- a/src/gallium/auxiliary/gallivm/lp_bld_gather.c
>> +++ b/src/gallium/auxiliary/gallivm/lp_bld_gather.c
>> @@ -525,7 +525,7 @@ lp_build_gather(struct gallivm_state *gallivm,
>>        if (vec_zext) {
>>           res = LLVMBuildZExt(gallivm->builder, res, res_t, "");
>>           if (vector_justify) {
>> -#if PIPE_ARCH_BIG_ENDIAN
>> +#ifdef PIPE_ARCH_BIG_ENDIAN
>>              unsigned sv = dst_type.width - src_width;
>>              res = LLVMBuildShl(gallivm->builder, res,
>>                                 lp_build_const_int_vec(gallivm, res_type, sv), "");
>>
>
> Oops, yes.
> Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Whomever merges this please add the following tags

Fixes: 8ac3c1bf1ab "gallivm: optimize 16bit->32bit gather path a bit"
Cc: mesa-stable at lists.freedesktop.org

Thanks !
Emil


More information about the mesa-dev mailing list