[Mesa-dev] [PATCH 4/5] configure: explicitly require shared glapi for enable-dri

[Steven Newbury]

On Thu, 2017-01-19 at 15:16 +0000, Emil Velikov wrote:
> On 19 January 2017 at 00:18, Steven Newbury <steve at snewbury.org.uk>
> wrote:
> > On Wed, 2016-12-07 at 13:25 +0000, Emil Velikov wrote:
> > > From: Emil Velikov <emil.velikov at collabora.com>
> > > 
> > > We've been using and depending on it for at least a couple of
> > > years.
> > > Make it obvious and error out, should one opt for it.
> > > 
> > > Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> > > ---
> > >  configure.ac | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/configure.ac b/configure.ac
> > > index 162c31a..f1f41db 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -1577,9 +1577,7 @@ if test "x$enable_shader_cache" = "xyes";
> > > then
> > >  fi
> > > 
> > >  if test "x$enable_dri" = xyes; then
> > > -    if test "$enable_static" = yes; then
> > > -        AC_MSG_ERROR([Cannot use static libraries for DRI
> > > drivers])
> > > -    fi
> > > +    require_dri_shared_libs_and_glapi "DRI"
> > > 
> > >      # not a hard requirement as swrast does not depend on it
> > >      if test "x$have_libdrm" = xyes; then
> > 
> > What is this change supposed to do?  It just gives the below error
> > here:
> > 
> 
> Add an extra "Thou Shalt Not use static glapi" on top of the existing
> cannot build with static.
> 
> > require_dri_shared_libs_and_glapi: command not found
> 
> Should have moved the function further up. Patch coming in a second.
> 
I thought I grepped configure.ac for the function, obviously I didn't.
:-)

Added my Tested-by to the follow up patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170119/3191608e/attachment.sig>