[Mesa-dev] [PATCH] gallium/hud: add missing break in hud_cpufreq_graph_install()

Samuel Pitoiset samuel.pitoiset at gmail.com
Fri Jan 20 09:07:36 UTC 2017



On 01/20/2017 03:57 AM, Emil Velikov wrote:
> On 20 January 2017 at 00:19, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>  src/gallium/auxiliary/hud/hud_cpufreq.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/gallium/auxiliary/hud/hud_cpufreq.c b/src/gallium/auxiliary/hud/hud_cpufreq.c
>> index 19a6f08c4f..78754b28a9 100644
>> --- a/src/gallium/auxiliary/hud/hud_cpufreq.c
>> +++ b/src/gallium/auxiliary/hud/hud_cpufreq.c
>> @@ -149,6 +149,7 @@ hud_cpufreq_graph_install(struct hud_pane *pane, int cpu_index,
>>        break;
>>     case CPUFREQ_MAXIMUM:
>>        snprintf(gr->name, sizeof(gr->name), "%s-Max", cfi->name);
>> +      break;
>>     default:
> Hit me just as I pressed enter - we're leaking in the default path.
> Worth fixing with follow-up patch ?

Yes, there are other issues. I will some of them.

>
> -Emil
>


More information about the mesa-dev mailing list