[Mesa-dev] [PATCH 1/2] spirv: don't assert with location decorations on non i/o variables

[Jason Ekstrand]

On Fri, Jan 20, 2017 at 8:45 AM, Lionel Landwerlin <
lionel.g.landwerlin at intel.com> wrote:

> Some applications might add location decoration to samplers. Rather
> than raising an error it seems it would make more sense to just
> discard these decorations.
>

That's annoying but not the end of the world.  Please CC to 17.0 stable
(but not 13.0)  Also, please try and file a bug with the Unit3D people as
this is a bug in their SPIR-V generator.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  src/compiler/spirv/vtn_variables.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_
> variables.c
> index 61a3701e43..61373d4e88 100644
> --- a/src/compiler/spirv/vtn_variables.c
> +++ b/src/compiler/spirv/vtn_variables.c
> @@ -1199,7 +1199,8 @@ var_decoration_cb(struct vtn_builder *b, struct
> vtn_value *val, int member,
>           is_vertex_input = false;
>           location += vtn_var->patch ? VARYING_SLOT_PATCH0 :
> VARYING_SLOT_VAR0;
>        } else {
> -         unreachable("Location must be on input or output variable");
> +         vtn_warn("Location must be on input or output variable");
>
+         return;
>        }
>
>        if (vtn_var->var) {
> --
> 2.11.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170120/7fa67071/attachment-0001.html>